fix(serve): ignore git stderr noise when parsing subprocess output#421
Merged
tinder-maxwellelliott merged 3 commits intoJul 10, 2026
Merged
Conversation
ProcessGitClient merged stdout and stderr, so background auto-pack messages could be mistaken for a commit SHA and break checkout during impacted-targets queries. Capture stdout only and parse rev-parse output as a 40-char SHA. Co-authored-by: Cursor <cursoragent@cursor.com>
The test-jre21 ubuntu-latest job can run out of disk during //cli:E2ETest, causing unrelated failures (No space left on device). Reclaim space from preinstalled toolchains the job does not use. Co-authored-by: Cursor <cursoragent@cursor.com>
Deleting /usr/local/lib/android broke rules_android during analysis. Reclaim space from dotnet/ghc/docker only, and route Bazel's output_user_root to /mnt on hosted runners so E2ETest has more headroom than root disk. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
servefailures when git writes background auto-pack messages to stderr (e.g.Auto packing the repository in background for optimum performance.) duringrev-parse/checkout.ProcessGitClientnow captures stdout only for subprocess parsing, while stderr is still printed to service logs on failure.resolveShaadditionally requires a 40-character hex SHA line, guarding against any stray stdout noise.Test plan
bazel test //cli:GitClientTest //cli:ServeCommandTest--gitEngine=subprocessagainst a large repo and confirm/impacted_targets_with_distancesno longer fails with a pathspec error during background git auto-packMade with Cursor