Texture decoding test#15
Closed
AnriTool wants to merge 9 commits intoTimic3:masterfrom
AnriTool:texture-decoding-test
Closed
Texture decoding test#15AnriTool wants to merge 9 commits intoTimic3:masterfrom AnriTool:texture-decoding-test
AnriTool wants to merge 9 commits intoTimic3:masterfrom
AnriTool:texture-decoding-test
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a test to check the decoded image with the result from dxt-js. The result of dxt-js was written to json file in advance.
I made the spread of the expected result in +-1 value. The difference of a pixel, even if all its colors will be shifted by 1 - not noticeable.
Difference in 1 unit can occur due to divisions and rounding of values, when calculating the palette.
I made tests on dxt1, dxt3 and dxt5.
dxt-js does not support dxt2, dxt4, these encoding methods differ from dxt3 and dxt4 only by multiplication of pixel colors by alpha, there is no such parameter in dxt-js.