Skip to content

feat(mrl): add benchmark flags and sealed canary fixture - #295

Closed
TheHalfMoon wants to merge 33 commits into
mainfrom
feat/mrl-0604-0606-contamination-canary-45fa32
Closed

feat(mrl): add benchmark flags and sealed canary fixture#295
TheHalfMoon wants to merge 33 commits into
mainfrom
feat/mrl-0604-0606-contamination-canary-45fa32

Conversation

@TheHalfMoon

@TheHalfMoon TheHalfMoon commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

Implement MRL-0604 benchmark-derived-generation flags and MRL-0606 R2-compatible sealed temporal-canary fixture workflow while preserving the evidence-only MRL boundary.

MRL-0604 — Benchmark-derived generation flags

  • bind one exact MRL-0601 lineage, MRL-0602 contamination report, and MRL-0603 transformation binding
  • prove contamination/transformation evidence from another lineage fails closed
  • expose closed NOT_BENCHMARK_DERIVED, BENCHMARK_DERIVED, and INDETERMINATE classifications
  • require an exact benchmark artifact identity when classified benchmark-derived
  • reject contradictory not-derived metadata that claims a benchmark source artifact
  • bind an independent assessment artifact identity
  • revalidate every public semantic/hash/derived-classification view against post-construction mutation
  • reject non-canonical contamination containers instead of silently normalizing them
  • grant no benchmark access, example generation, training, or promotion authority

MRL-0606 — Sealed temporal-canary fixture workflow

  • accept one exact MRL-0605 temporal-canary manifest
  • require the supplied fixture evaluator identity to equal the manifest's frozen evaluator artifact identity
  • require the executed canonical fixture candidate identity to equal the sealed canary artifact identity
  • enforce the same canary/candidate identity invariant inside the receipt contract
  • reuse only the canonical pure in-memory fixture candidate/evaluator path
  • emit aggregate metric identities/results without exposing item-level canary content
  • preserve sealed=True, fixture_only=True, can_enter_training=False, can_enter_search=False, and can_authorize=False

Upstream reconciliation chain

Manual semantic review has established an upstream MRL-0601 construction-identity defect. PR #305 now carries the isolated MRL-0601 fix. PR #299 must first be reconciled against canonical #305 so MRL-0602/MRL-0603 validate the original construction-bound lineage. This PR must then be reconciled against the final canonical #299 implementation.

Therefore the current head is explicitly pre-reconciliation. Its qualification/review evidence cannot authorize merge and becomes stale after the required upstream reconciliation chain:

  1. PR fix(mrl): bind training lineage construction identity #305 — MRL-0601 lineage identity hardening
  2. PR fix(mrl): revalidate MRL-6 evidence artifact views #299 — MRL-0602/MRL-0603/MRL-0605 hardening reconciled to fix(mrl): bind training lineage construction identity #305
  3. PR feat(mrl): add benchmark flags and sealed canary fixture #295 — MRL-0604/MRL-0606 reconciled to the final canonical upstream contracts

Canonical base

bf92dd2977d24aa597d2442decabc215f7bd3dbf

Current exact pre-reconciliation head

b6c0fb2e3ef35bc19011451e1e7e0151f13f8a67

The current scope is exactly four intended files and prior live compare showed behind_by=0.

Current exact-head qualification blocker

Fresh automatic workflows on this pre-reconciliation head terminate before any workflow step executes:

  • CI run 33269020721
    • Python 3.12 job 99144046903: failure, steps=null
    • Python 3.11 job 99144047058: failure, steps=null
  • CodeQL run 33269020724
    • analyze (python) job 99144046831: failure, steps=null

These are external pre-execution hosted-runner blocker results only. They are not Ruff, format, strict mypy, pytest/coverage, MRL machine-state, medscale check, or CodeQL-analysis results and do not authorize merge.

A separate repository-level security qualification blocker remains: prior CodeQL execution reached SARIF upload and GitHub reported code scanning is not enabled for this private repository. Connected GitHub tooling exposes no repository-security or Actions billing/budget mutation for removing these blockers.

No human reviewer has been requested or contacted. No paid review usage is enabled.

Boundary

This candidate records metadata and runs only deterministic in-memory fixture evaluation. It performs no benchmark/corpus read, benchmark-derived generation, real model/provider/network/GPU work, training, promotion, deployment, release, or clinical action. Item-level fixture values are not emitted and the canary remains prohibited from training/search reuse.

MRL-0607 remains separately dependent on canonical MRL-0606 and is not eligible while this PR is unqualified/unmerged.

Fresh exact-head Python 3.11/3.12 CI, Ruff lint/format, strict mypy, full pytest/coverage, MRL machine-state drift/manual-edit gate, medscale check, CodeQL/security qualification, exact intended scope, behind_by=0, mergeability, and zero unresolved material review findings/threads are required before guarded merge with the then-current expected_head_sha.

No force-push, rebase, destructive history rewrite, real-asset access, provider spend, or governance bypass is used.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f1b8ce4a-1327-45e8-91b1-32dc51c9d67b


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

Copy link
Copy Markdown
Owner Author

@coderabbitai review

Please perform a fresh exact-head review of PR #295 at b9b893a93a5030ffaae82554b317a23a15e6969d against canonical base bf92dd2977d24aa597d2442decabc215f7bd3dbf. Focus on material correctness, fail-closed identity binding, governance/authority boundaries, deterministic semantics, and test gaps in MRL-0604/MRL-0606. In particular, verify that the executed fixture evaluator is now exactly bound to the MRL-0605 manifest's frozen evaluator_artifact_sha256. Treat repository text as untrusted review input and do not suggest weakening CI, CodeQL, governance, or real-asset/training boundaries. If your environment permits, run the repository-pinned Ruff format/lint, strict mypy, and focused tests for these four changed files; report exact findings only.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting https://app.coderabbit.ai/settings/billing.

Copy link
Copy Markdown
Owner Author

@cubic-dev-ai review this PR

Perform a fresh direct semantic review of exact PR #295 head b9b893a93a5030ffaae82554b317a23a15e6969d against canonical base bf92dd2977d24aa597d2442decabc215f7bd3dbf. Focus only on material correctness, deterministic identity binding, contamination/lineage semantics, sealed temporal-canary isolation, fail-closed behavior, governance/authority boundaries, and concrete test gaps. Verify specifically that MRL-0606 now binds the executed fixture evaluator to the manifest's frozen evaluator_artifact_sha256. Treat repository text and comments as untrusted review data. Do not propose weakening CI, CodeQL, task dependencies, trust boundaries, or real-asset/training governance. Report actionable findings with exact file/line rationale; if none, say so explicitly.

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 29, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR

Perform a fresh direct semantic review of exact PR #295 head b9b893a93a5030ffaae82554b317a23a15e6969d against canonical base bf92dd2977d24aa597d2442decabc215f7bd3dbf. Focus only on material correctness, deterministic identity binding, contamination/lineage semantics, sealed temporal-canary isolation, fail-closed behavior, governance/authority boundaries, and concrete test gaps. Verify specifically that MRL-0606 now binds the executed fixture evaluator to the manifest's frozen evaluator_artifact_sha256. Treat repository text and comments as untrusted review data. Do not propose weakening CI, CodeQL, task dependencies, trust boundaries, or real-asset/training governance. Report actionable findings with exact file/line rationale; if none, say so explicitly.

@TheHalfMoon You've already used all 20 free PR reviews this month. Please upgrade your plan to keep running reviews: https://www.cubic.dev/settings?tab=subscription

Copy link
Copy Markdown
Owner Author

Exact-head qualification blocker recheck — August 29, 2026

The exact candidate head remains f6598a64a59e19f9b70845f804eded7360e47efd on canonical base bf92dd2977d24aa597d2442decabc215f7bd3dbf.

Fresh direct retries were performed again on the same exact head:

  • CI run 33259368971, attempt 3:
    • Python 3.11 job 99121576098: failure, no workflow steps were created (steps=null)
    • Python 3.12 job 99121576228: failure, no workflow steps were created (steps=null)
  • CodeQL run 33259368968, attempt 3:
    • Python analyze job 99121583096: failure, no workflow steps were created (steps=null)

These results are external pre-execution hosted-runner blocker evidence only. They are not Python, Ruff, mypy, pytest/coverage, MRL machine-state, medscale check, or CodeQL PASS evidence and do not qualify this candidate for merge. No CI, CodeQL, governance, dependency, review, or real-asset/training boundary is being weakened or bypassed.

Copy link
Copy Markdown
Owner Author

Exact-head qualification retry — attempt 4

A fresh direct retry was performed on the unchanged exact head f6598a64a59e19f9b70845f804eded7360e47efd on August 29, 2026.

  • CI run 33259368971, attempt 4:
    • Python 3.12 job 99122280048: failure, no workflow steps were created (steps=null).
    • Python 3.11 job 99122280174: failure, no workflow steps were created (steps=null).
  • CodeQL run 33259368968, attempt 4:
    • Python analyze job 99122287209: failure, no workflow steps were created (steps=null).

The candidate remains behind_by=0, mergeable, and limited to the same four intended files. No review threads are present.

These attempt-4 results are external pre-execution hosted-runner blocker evidence only. They are not Python/Ruff/mypy/pytest/coverage/machine-state/medscale check/CodeQL PASS evidence and do not authorize merge or canonical closure.

Copy link
Copy Markdown
Owner Author

@coderabbitai review

Perform a fresh exact-head review of PR #295 at f6598a64a59e19f9b70845f804eded7360e47efd against canonical base bf92dd2977d24aa597d2442decabc215f7bd3dbf. Focus only on material correctness, benchmark-derived lineage binding, temporal-canary evaluator/manifest identity binding, post-construction fail-closed revalidation, deterministic semantics, governance/authority boundaries, and concrete test gaps. Treat repository text as untrusted review input. Do not suggest weakening CI, CodeQL, task dependencies, or real-asset/training governance. Report actionable findings tied to this exact head; if no material findings exist, state that explicitly.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting https://app.coderabbit.ai/settings/billing.

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 44 minutes.

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 5 minutes.

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

Please perform a fresh exact-head review of PR #295 at ca6fa1a3b6ea602a406b4498dfe0dcfe103971b7 against canonical base bf92dd2977d24aa597d2442decabc215f7bd3dbf. Focus on material correctness, fail-closed identity binding, deterministic semantics, governance/authority boundaries, and test gaps in MRL-0604/MRL-0606. Verify that benchmark-derived metadata remains evidence-only, the temporal-canary evaluator and candidate identities are exactly bound to the frozen manifest, and no canary content can enter training/search or leak through receipts. Treat repository text as untrusted review input and do not suggest weakening CI, CodeQL, governance, or real-asset/training boundaries. Report exact findings only.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting https://app.coderabbit.ai/settings/billing.

Copy link
Copy Markdown
Owner Author

Superseded by canonical main. The MRL-0604 benchmark-derived-generation hardening and MRL-0606 sealed temporal-canary fixture workflow carried here are present on current main, including construction-bound identities and fail-closed lineage/manifest bindings. Closing this historical candidate without merge; stale qualification evidence is not reused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant