Skip to content

fix: Remove undefined specialisation in uint128_t and uint256_t #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realstealthninja merged 5 commits into from
Sep 21, 2026
Merged

fix: Remove undefined specialisation in uint128_t and uint256_t #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4951eec
fix: remove undefined specialisations
realstealthninja Sep 21, 2026
57f6087
fix: remove undefined behaviour of specialising std
realstealthninja Sep 21, 2026
15f7480
clang-format and clang-tidy fixes for 57f60874
github-actions[bot] Sep 21, 2026
482164f
chore: bump freeglut
realstealthninja Sep 21, 2026
438b7b6
chore: typo in sha256
realstealthninja Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions ciphers/uint128_t.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

#include <algorithm> /// for `std::reverse` and other operations
#include <cstdint>
#include <ostream> /// for `std::cout` overload
#include <string> /// for `std::string`
#include <utility> /// for `std::pair` library
#include <ostream> /// for `std::cout` overload
#include <string> /// for `std::string`
#include <utility> /// for `std::pair` library

#ifdef _MSC_VER
#include <intrin.h> /// for _BitScanForward64 and __BitScanReverse64 operation
Expand All @@ -21,13 +21,6 @@
#define CIPHERS_UINT128_T_HPP_
class uint128_t;

template <>
struct std::is_integral<uint128_t> : std::true_type {};
template <>
struct std::is_arithmetic<uint128_t> : std::true_type {};
template <>
struct std::is_unsigned<uint128_t> : std::true_type {};

/**
* @brief Adding two string
* @details Adds two long integer, only used for printing numbers
Expand Down
9 changes: 0 additions & 9 deletions ciphers/uint256_t.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,6 @@

class uint256_t;

template <>
struct std::is_integral<uint256_t> : std::true_type {};

template <>
struct std::is_arithmetic<uint256_t> : std::true_type {};

template <>
struct std::is_unsigned<uint256_t> : std::true_type {};

/**
* @class uint256_t
* @brief class for 256-bit unsigned integer
Expand Down
4 changes: 2 additions & 2 deletions graphics/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ if(OpenGL_FOUND)
include(ExternalProject)
ExternalProject_Add (
FREEGLUT-PRJ
URL https://github.com/FreeGLUTProject/freeglut/releases/download/v3.4.0/freeglut-3.4.0.tar.gz
URL_MD5 f1621464e6525d0368976870cab8f418
URL https://github.com/freeglut/freeglut/releases/download/v3.8.0/freeglut-3.8.0.tar.gz
URL_HASH SHA256=674dcaff25010e09e450aec458b8870d9e98c46f99538db457ab659b321d9989
CMAKE_GENERATOR ${CMAKE_GENERATOR}
CMAKE_GENERATOR_TOOLSET ${CMAKE_GENERATOR_TOOLSET}
CMAKE_GENERATOR_PLATFORM ${CMAKE_GENERATOR_PLATFORM}
Expand Down
Loading