Genreport variable bug#4035
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Mar 24, 2026
Merged
Conversation
luarss
suggested changes
Mar 23, 2026
docker/Dockerfile.builder
Outdated
| chmod +x /usr/local/bin/wrapped-cc/g++ | ||
| # Add compiler wrapper scripts for reproducible builds | ||
| COPY --link etc/setup_compiler_wrappers.sh /tmp/ | ||
| RUN sh /tmp/setup_compiler_wrappers.sh && rm /tmp/setup_compiler_wrappers.sh |
Contributor
There was a problem hiding this comment.
why is this diff inside this PR
Contributor
Author
There was a problem hiding this comment.
Ohh I see, it is the Git mix up :) I thought I was on main branch but accidentally pushes changes from feature. I'll correct it and push it again. Thankyou for you time.
docker/Dockerfile.dev
Outdated
| chmod +x /usr/local/bin/wrapped-cc/g++ | ||
| # add compiler wrapper scripts for reproducible builds | ||
| COPY setup_compiler_wrappers.sh /tmp/ | ||
| RUN sh /tmp/setup_compiler_wrappers.sh && rm /tmp/setup_compiler_wrappers.sh |
etc/setup_compiler_wrappers.sh
Outdated
| cat > "$WRAPPER_DIR/gcc" << 'WRAPPER' | ||
| #!/bin/sh | ||
| exec /usr/bin/gcc -D__TIME__="\"0\"" -D__DATE__="\"0\"" -D__TIMESTAMP__="\"0\"" -Wno-builtin-macro-redefined "$@" | ||
| WRAPPER |
- gen_report() in flow/util/genReport.py incorrectly referenced the global iteration variable 'd' instead of the function parameter 'data' on line 173. - Changed d['drcs'] to data['drcs'] to fix the logic bug. Signed-off-by: Vi-shub <[email protected]>
Vi-shub
force-pushed
the
genreport-variable-bug
branch
from
aae4641 to
9d36f7e
Compare
luarss
approved these changes
Mar 23, 2026
Contributor
Author
|
Hi @maliberty can you review this. Thanks for you time, happy to work with you. |
maliberty
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4033
This PR fixes a logic bug in flow/util/genReport.py.
In gen_report(name, data) on line 173, the code incorrectly referenced the global loop variable
d["drcs"]instead of the function parameterdata["drcs"].While this did not break the current flow because the global
dfrom the main loop happened to mirrordata, it broke function encapsulation and would silent-fail if gen_report() was ever called outside of that specific loop iteration. This PR changes it to properly evaluate its passed argument.@luarss @maliberty can you please review this. It is small typo error but needs to be correct the functionality.
Thanks for you time :)