setup: fix macOS thread count using hw.logicalcpu instead of hw.ncpu#4030
Open
Divinesoumyadip wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
Conversation
Signed-off-by: Divinesoumyadip <[email protected]>
Author
|
@maliberty @luarss could you approve the workflows to run CI? Happy to address any review feedback. |
luarss
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4028
Currently,
etc/DependencyInstaller.shusessysctl -n hw.ncputo determine the thread count on macOS. However,hw.ncpuonly returns the number of physical cores. This ends up underestimating the available parallelism, particularly on Intel Macs that utilize hyperthreading.This PR replaces
hw.ncpuwithhw.logicalcpu.hw.logicalcpucorrectly returns all logical cores (including hyperthreaded ones), making it the exact macOS equivalent to thenproccommand on Linux.hw.ncpureturns4, whilehw.logicalcpucorrectly returns8.10.This swap ensures we are fully utilizing the available CPU resources to speed up dependency installation on macOS.