Fix(rebar): use shell geometry if rebars are not exported as SweptDiskSolids#156
Open
MiguelG97 wants to merge 5 commits intoThatOpen:mainfrom
Open
Fix(rebar): use shell geometry if rebars are not exported as SweptDiskSolids#156MiguelG97 wants to merge 5 commits intoThatOpen:mainfrom
MiguelG97 wants to merge 5 commits intoThatOpen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #146
Description
This PR fixes how reinforcing rebars are loaded into fragments when they aren’t exported as SweptDiskSolid. if a rebar doesn’t have a valid directrix axis, it falls back to loadShellGeometry so it still shows up in the scene.
Additional context
Before, the code assumed all IFCREINFORCINGBAR geometries had a SweptDiskSolid with a directrix. But some IFC exports (like from Tekla) might be configured to export rebars as IfcFacetedBrep, which doesn’t have that data. That made loadCircleExtrusionGeometry fail and the rebars wouldn’t load.
rebars.not.rendering.mov
Now, this change checks if the sweep directrix exists and uses the shell loader if it doesn’t, so all rebars get parsed and rendered correctly.
rebars.rendering.mov
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).