Add NOT operator and event parameter conditions to action triggers#217
Draft
Add NOT operator and event parameter conditions to action triggers#217
Conversation
Add `not` field to function, eventEmitted, logEmitted, and comparable int/str filters. Replace the old unsupported `parameter` map on eventEmitted with typed `parameters` supporting string and int comparisons. Update generated Conjure structs to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notfield tofunction,eventEmitted,logEmitted, and comparable int/str filters (value,gasUsed,gasLimit,fee,from,to), allowing users to negate any filter condition in theiraction trigger YAML.
parametermap oneventEmittedwith typedparametersarray supportingstring(exact match) andint(eq/gt/gte/lt/lte) comparisons against decoded event arguments.MsgIdAndParameterForbiddenconstraint — parameters now work with bothidandnamematching.
ParameterCondition,Notfields onEventEmittedFilter,FunctionFilter,LogEmittedFilter,ComparableInt,ComparableStr).Example YAML
Test plan
filter types
actions-trigger-service (requires companion PR in tenderly-core)