Skip to content

fix(search): honor recall embedding timeout#272

Open
YOMXXX wants to merge 1 commit into
TencentCloud:mainfrom
YOMXXX:fix/memory-tools-recall-timeout
Open

fix(search): honor recall embedding timeout#272
YOMXXX wants to merge 1 commit into
TencentCloud:mainfrom
YOMXXX:fix/memory-tools-recall-timeout

Conversation

@YOMXXX

@YOMXXX YOMXXX commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • pass embedding.recallTimeoutMs ?? embedding.timeoutMs from TdaiCore into both agent search tools
  • forward the timeout to query embedding calls in tdai_memory_search and tdai_conversation_search
  • add regression coverage for recall override and timeout fallback

Why

recallTimeoutMs is already documented as the user-facing recall-path embedding timeout and auto-recall honors it, but the agent-callable search tools still called embed(query) without per-call options. A slow embedding provider could therefore ignore the shorter recall timeout during interactive tool search.

Tests

  • npm test -- src/core/tdai-core.test.ts
  • npm test
  • npm run build

@Maxwell-Code07

Copy link
Copy Markdown
Collaborator

We have received multiple PRs submitted by you. Thank you for your consistent contributions. We will review them one by one and provide feedback accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants