fix(search): honor recall embedding timeout#272
Open
YOMXXX wants to merge 1 commit into
Open
Conversation
Collaborator
|
We have received multiple PRs submitted by you. Thank you for your consistent contributions. We will review them one by one and provide feedback accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embedding.recallTimeoutMs ?? embedding.timeoutMsfromTdaiCoreinto both agent search toolstdai_memory_searchandtdai_conversation_searchWhy
recallTimeoutMsis already documented as the user-facing recall-path embedding timeout and auto-recall honors it, but the agent-callable search tools still calledembed(query)without per-call options. A slow embedding provider could therefore ignore the shorter recall timeout during interactive tool search.Tests
npm test -- src/core/tdai-core.test.tsnpm testnpm run build