Skip to content

fix(embedding): forward proxy and timeout config#271

Open
YOMXXX wants to merge 1 commit into
TencentCloud:mainfrom
YOMXXX:fix/embedding-config-forwarding
Open

fix(embedding): forward proxy and timeout config#271
YOMXXX wants to merge 1 commit into
TencentCloud:mainfrom
YOMXXX:fix/embedding-config-forwarding

Conversation

@YOMXXX

@YOMXXX YOMXXX commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Forward embedding.proxyUrl into the remote embedding service so qclaw proxy mode uses the configured local proxy instead of silently calling the remote base URL directly.
  • Forward embedding.timeoutMs into the embedding service so service-level default timeouts match user config when call sites do not pass an override.
  • Add a focused store factory regression test for qclaw proxy + timeout config propagation.

Root cause

parseConfig() exposes embedding.proxyUrl and embedding.timeoutMs, and OpenAIEmbeddingService supports both fields, but createStoreBundle() only forwarded provider/baseUrl/apiKey/model/dimensions/sendDimensions/maxInputChars. The factory boundary dropped proxy and timeout settings.

Tests

  • RED: npm test -- src/core/store/factory.test.ts failed because createEmbeddingService() received no proxyUrl or timeoutMs.
  • GREEN: npm test -- src/core/store/factory.test.ts
  • npm test
  • npm run build

@Maxwell-Code07

Copy link
Copy Markdown
Collaborator

We have received multiple PRs submitted by you. Thank you for your consistent contributions. We will review them one by one and provide feedback accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants