fix(embedding): forward proxy and timeout config#271
Open
YOMXXX wants to merge 1 commit into
Open
Conversation
Collaborator
|
We have received multiple PRs submitted by you. Thank you for your consistent contributions. We will review them one by one and provide feedback accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embedding.proxyUrlinto the remote embedding service so qclaw proxy mode uses the configured local proxy instead of silently calling the remote base URL directly.embedding.timeoutMsinto the embedding service so service-level default timeouts match user config when call sites do not pass an override.Root cause
parseConfig()exposesembedding.proxyUrlandembedding.timeoutMs, andOpenAIEmbeddingServicesupports both fields, butcreateStoreBundle()only forwarded provider/baseUrl/apiKey/model/dimensions/sendDimensions/maxInputChars. The factory boundary dropped proxy and timeout settings.Tests
npm test -- src/core/store/factory.test.tsfailed becausecreateEmbeddingService()received noproxyUrlortimeoutMs.npm test -- src/core/store/factory.test.tsnpm testnpm run build