Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions cli/internal/cmdutil/authrefresh_http_classification_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package cmdutil

import (
"context"
"net/http"
"net/http/httptest"
"testing"

"github.com/Tencent/WeKnora/cli/internal/secrets"
"github.com/Tencent/WeKnora/cli/internal/testutil"
sdk "github.com/Tencent/WeKnora/client"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestRejectedAutomaticRefreshPreservesHTTPClassification(t *testing.T) {
for _, status := range []int{http.StatusUnauthorized, http.StatusForbidden} {
t.Run(http.StatusText(status), func(t *testing.T) {
testutil.XDGTempDir(t)
store, err := secrets.NewFileStore()
require.NoError(t, err)
require.NoError(t, store.Set("test", "refresh", "rejected-refresh"))
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path == "/api/v1/auth/refresh" {
w.WriteHeader(status)
_, _ = w.Write([]byte(`{"message":"refresh rejected"}`))
return
}
assert.Equal(t, "/api/v1/knowledge/doc-test", r.URL.Path)
w.WriteHeader(http.StatusUnauthorized)
}))
defer server.Close()
transport := NewAuthRetryTransport(http.DefaultTransport, "expired-access",
func(ctx context.Context) (string, error) {
return RefreshAndPersist(ctx, store, sdk.NewClient(server.URL), "test")
})
client := sdk.NewClient(server.URL, sdk.WithBearerToken("expired-access"), sdk.WithTransport(transport))
_, err = client.GetKnowledge(context.Background(), "doc-test")
require.Error(t, err)
wrapped := WrapHTTP(err, "fetch document")
assert.Equal(t, ClassifyHTTPStatus(status), wrapped.Code)
assert.True(t, IsAuthError(wrapped))
assert.Equal(t, 3, ExitCode(wrapped))
})
}
}
7 changes: 6 additions & 1 deletion cli/internal/cmdutil/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ type Error struct {
Silent bool
RetryArgv []string // Directly-executable argv array, distinct from prose Hint
RetryAfterSeconds int // HTTP Retry-After header semantics (transport-level retry hint)
Detail any // Structured detail for envelope.error.detail (e.g. unknown-subcommand available[])
Detail any // Structured detail for envelope.error.detail (e.g. unknown-subcommand available[])
Risk *RiskInfo
}

Expand Down Expand Up @@ -398,6 +398,11 @@ func ClassifyHTTPError(err error) ErrorCode {
return ""
}
msg := err.Error()
var apiErr *sdk.APIError
if errors.As(err, &apiErr) {
// SDK and net/http wrap refresh failures; inspect the HTTP cause.
msg = apiErr.Error()
}
rest, ok := strings.CutPrefix(msg, "HTTP error ")
if !ok {
return CodeNetworkError
Expand Down
Loading