TeamRandomizer: strict command match & code style#420
Open
mikebjoyce wants to merge 1 commit into
Open
Conversation
Enforce an exact, trimmed, case-insensitive chat command match to prevent accidental team randomization when admins mention the command word in normal chat (e.g., "I'm going to randomize the teams"). Adds an explanatory comment and guard check. Also applies stylistic cleanups and formatting: convert quotes to double quotes, add trailing commas, and reformat argument/await lines for readability.
Author
|
The accidental trigger occurs in admin chat specifically, not normal player chat, which is already blocked by an earlier guard. This fix ensures only a bare !randomize message in admin chat triggers the shuffle, not sentences that happen to contain the command word. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce an exact, trimmed, case-insensitive chat command match to prevent accidental team randomization when admins mention the command word in normal chat (e.g., "I'm going to randomize the teams"). Adds an explanatory comment and guard check. Also applies stylistic cleanups and formatting: convert quotes to double quotes, add trailing commas, and reformat argument/await lines for readability.