Skip to content

Dockerfile and Action for creating Docker image in GitHub's registry#317

Open
Sentennial wants to merge 4 commits into
Team-Silver-Sphere:masterfrom
Sentennial:docker-image-with-action
Open

Dockerfile and Action for creating Docker image in GitHub's registry#317
Sentennial wants to merge 4 commits into
Team-Silver-Sphere:masterfrom
Sentennial:docker-image-with-action

Conversation

@Sentennial

Copy link
Copy Markdown
Contributor

No description provided.

@sullivandavid42

Copy link
Copy Markdown

Any update about this merge request ? Would be glad to see this container in action ! :)

@werewolfboy13

Copy link
Copy Markdown
Collaborator

@sullivandavid42 legit didn’t know this was a PR. The docker file at a minimum is broken as such I can’t push this. Will make a change request when I can.

@wojski

wojski commented Apr 13, 2024

Copy link
Copy Markdown

Yes, you don't need to install nodejs / pm2 in your system. Its just an option if somebody want to run it via docker (For example we are running it in docker from day 0)

@wojski

wojski commented Apr 13, 2024

Copy link
Copy Markdown

Working dockerfile if anyone need ;)

FROM node:18.17-alpine
USER node
RUN mkdir -p /home/node/app
WORKDIR /home/node/app
COPY --chown=node . .
RUN yarn install && yarn cache clean
CMD ["node", "index.js"]

@D4n2021

D4n2021 commented Apr 13, 2024

Copy link
Copy Markdown

Working dockerfile if anyone need ;)

FROM node:18.17-alpine
USER node
RUN mkdir -p /home/node/app
WORKDIR /home/node/app
COPY --chown=node . .
RUN yarn install && yarn cache clean
CMD ["node", "index.js"]

So is this for Windows aswell then or just Linux? Because here it only lists Linux, although top right says "multiplatform".

grafik

@fantinodavide

Copy link
Copy Markdown
Contributor

Working dockerfile if anyone need ;)

FROM node:18.17-alpine
USER node
RUN mkdir -p /home/node/app
WORKDIR /home/node/app
COPY --chown=node . .
RUN yarn install && yarn cache clean
CMD ["node", "index.js"]

So is this for Windows aswell then or just Linux?

Docker works on Linux and Windows (on WSL) and the docker image is used to standardize the environment that will run an application, regardless of the OS.

@D4n2021

D4n2021 commented Apr 13, 2024

Copy link
Copy Markdown

Just edited my previous post.

@fantinodavide

Copy link
Copy Markdown
Contributor

Just edited my previous post.

This is becoming off-topic but I can suggest to read this page in which everything is very well explained: https://docs.docker.com/get-started/overview/
If you need more clarifications I also suggest to move this conversation on discord, feel free to DM me, my username is jetdave

@Team-Silver-Sphere Team-Silver-Sphere deleted a comment from D4n2021 Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants