Fix stale RoutineSyncFoundationTests test broken by PR #207 - #216
Merged
Conversation
…ionP0 PR #207 added .atomicSingleActive to productionP0, so setRoutineGroupActive is now supported in production and a pending active-selection mutation must settle before that group's delete is admitted. The old test still asserted the pre-#207 behavior (delete ignores the pending selection) and failed. Rewrote it to assert the current, correct ordering.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testProductionDeleteIgnoresUnsupportedActiveIntentDependencyin RoutineSyncFoundationTests.swift was asserting a premise that 루틴 활성 전환 서버 동기화(setRoutineGroupActive) 구현 #207 invalidated: it expected a group delete to ignore a pending.selectActiveRoutineGroupmutation because production didn't supportsetRoutineGroupActiveyet..atomicSingleActivetoRoutineSyncServerCapabilities.productionP0, soproductionP0now supportssetRoutineGroupActive, andSwiftDataRoutineSyncRepository.dependenciesAreSatisfied's.deleteRoutineGroupcase correctly blocks the delete until the pending active-selection settles (per the doc comment already in that switch case). Nobody updated this test when 루틴 활성 전환 서버 동기화(setRoutineGroupActive) 구현 #207 merged, so it failed onmain.testProductionDeleteWaitsForPendingActiveSelectionUnderAtomicSingleActiveto assert the current, correct behavior: only the active-selection mutation is admitted, and the delete stays.waitingForServerContractuntil it settles.Test plan
xcodebuild test -only-testing:MoruTests/RoutineSyncFoundationTests— all tests pass, including the rewritten onexcodebuild test -only-testing:MoruTests/RoutineSyncCRUDIntegrationTests— all tests pass (no other test in this file combines.selectActiveRoutineGroupand.deleteRoutineGroupfor the same group under.productionP0)🤖 Generated with Claude Code