-
-
Notifications
You must be signed in to change notification settings - Fork 563
fix(form-core): π File input field - Picking a different file does not trigger rerender (deep equality issue with File/Blob objects) #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| * @private | ||
| */ | ||
| export function setBy(obj: any, _path: any, updater: Updater<any>) { | ||
| const isFile = updater instanceof File |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Native does not have File defined and will throw a ReferenceError. You cannot implement the fix this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. Truly. Good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. Truly. Good catch, thanks!
|
View your CI Pipeline Execution β for commit 9145eca
βοΈ Nx Cloud last updated this comment at |
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
==========================================
- Coverage 90.35% 89.52% -0.83%
==========================================
Files 38 48 +10
Lines 1752 1938 +186
Branches 444 489 +45
==========================================
+ Hits 1583 1735 +152
- Misses 149 182 +33
- Partials 20 21 +1 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
Issue: #1932
π― Changes
β Checklist
pnpm test:pr.π Release Impact