fix(query-db-collection): sync on-demand tanstack-query lifecycle #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ed2944d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
delphinaubin
changed the title
delphinaubin
commented
Dec 12, 2025
delphinaubin
force-pushed
the
fix-query-on-demand-sync-db-collection
branch
from
fce1597 to
d6e09f5
Compare
KyleAMathews
approved these changes
Dec 16, 2025
Collaborator
KyleAMathews
left a comment
KyleAMathews
left a comment
There was a problem hiding this comment.
Looks great! Could you make the one tweak & add a changeset to the .changeset? Thanks for putting up the fix!
| queries: { | ||
| gcTime: 5 * 60 * 1000, // 5 minutes | ||
| staleTime: 0, | ||
| staleTime: 100, // set a minimal staleTime to prevent a refetch |
Collaborator
There was a problem hiding this comment.
Could we use Infinity as this could flake potentially on slow CI
delphinaubin
force-pushed
the
fix-query-on-demand-sync-db-collection
branch
from
5e72a27 to
1b0ac9f
Compare
delphinaubin
force-pushed
the
fix-query-on-demand-sync-db-collection
branch
from
1b0ac9f to
ed2944d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This PR addresses the issue #998 and restores the complete TanStack Query lifecycle when using on-demand collection synchronization.
✅ Checklist
🚀 Release Impact