Repository navigation
feat(header): globe for the language, theme in the footer, system theme by default - #97
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systeminstead oflight, in the sharedhead-theme.blade.phpandlib/theme.ts. A stored choice still wins. Ships together with TableProApp/license#112, which carries the same two files.WIDE_HEADER_LOCALES: es and fr only (was de, es, fr, it, pt-BR). Widths re-measured in Chromium with GitHub at its widest. German is exactly 960 of 960.Why: in a rendered survey of 40 sites, all 7 sites with a theme control follow the OS by default and most keep it out of the header. Language stays at the top as a globe, because W3C, NN/g and USWDS ask for a visible control there and this site never redirects by language.