Repository navigation
feat(linux-grid): copy rows as a text table, JSON Lines, one row or INSERT without generated keys - #3862
Merged
Conversation
…NSERT without generated keys
…entity values in copied INSERTs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comfy-table(already in the lock through DuckDB), bordered as psql draws it. Numbers align right by the grid's own rule, a line break in a cell starts a continuation line, a tab expands to 8-column stops, other control characters and bidi controls show as escapes. A table past 64 MiB is refused with a toast.,, as IN Clause writes them. Offered only where the engine speaks SQL.OVERRIDING SYSTEM VALUE, SQL Server wraps the statements inSET IDENTITY_INSERT ... ON/OFF, the OFF in aGObatch of its own so a run that fails partway still ends it. Before, GENERATED ALWAYS and IDENTITY columns refused the rows.INTEGER PRIMARY KEYrowid alias as numbered, a default or not: SQLite 3.54 numbersINTEGER PRIMARY KEY DEFAULT 5from 1.Test plan
metadata::integer_primary_key_with_default_still_numbers_itselfreplacesinteger_primary_key_with_default_is_not_auto_increment: the old test pinned the opposite of what SQLite does.identity_insertintegration tests on PostgreSQL 18 and SQL Server 2022 run the copied INSERTs against identity, serial and system-versioned tables, and a SQL Server copy that fails on a duplicate key under XACT_ABORT ON.verify.sh --platform linux test: tablepro-core 835, sqlite 256, mssql 132, postgres 118 passed; the app's clipboard, data_grid, export, browse_tab and paste tests all passed.verify.sh --platform linux lintandl10n: clean.