fix(datagrid): show dimmed chevron on deleted rows per HIG disabled-appearance#1138
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a row is marked for deletion in the data grid (red strikethrough state), the dropdown / date / JSON / blob inline-edit chevron disappears entirely. The FK arrow stays visible. This inconsistency removes structural information about cell type and violates the macOS HIG "Disabled Appearance" rule:
Apple's own apps (Reminders.app for completed items) keep controls visible at reduced opacity rather than removing them. Removing controls disrupts spatial memory and structural information about cell type.
What changes
DataGridView+Columns.swift:91—isEditablepassed to the cell now reflects table-level editability only, decoupled from row-level deletion state. Deletion gating still happens ineditEligibility(the actual edit gate) where it belongs.DataGridCellView.swift— three small changes:chevronDisabledSF Symbol image variant intertiaryLabelColor(third color tier; matches Apple's "disabled" semantic alongsidesecondaryLabelColorfor normal andalternateSelectedControlTextColorfor emphasized selection).computeAccessoryRect()no longer hides the chevron whenvisualState.isDeleted. The accessory rect is computed whenever the column is structurally editable.drawAccessory()picks the disabled variant whenvisualState.isDeleted, falls through to emphasized/normal variants otherwise.mouseDown(with:)no-ops the chevron click when the row is deleted (forwards tosuper.mouseDownso row selection still works).Diff stats
Test plan
alternateSelectedControlTextColor(white)