Skip to content

fix: propagate error instead of panicking on non-UTF-8 reference name in checkout #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuishou68 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: propagate error instead of panicking on non-UTF-8 reference name in checkout #4481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/tabby-index/src/code/repository.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ pub fn checkout(repository: &CodeRepository, branch: &str) -> anyhow::Result<()>
let mut checkout_builder = git2::build::CheckoutBuilder::new();
checkout_builder.force();

repo.set_head(reference.name().unwrap())?;
let ref_name = reference
.name()
.ok_or_else(|| anyhow::anyhow!("Reference name is not valid UTF-8"))?;
repo.set_head(ref_name)?;
repo.checkout_head(Some(&mut checkout_builder))?;
Ok(())
}
Expand Down