Solve synchronization of KI's between KB and KER#13
Open
DaviddeBest-TNO wants to merge 6 commits intomainfrom
Open
Solve synchronization of KI's between KB and KER#13DaviddeBest-TNO wants to merge 6 commits intomainfrom
DaviddeBest-TNO wants to merge 6 commits intomainfrom
Conversation
3 tasks
Sophietje
reviewed
Apr 3, 2026
| self.registered = True | ||
| self.register_deferred_kis() | ||
| self.client.register_kb(self.info, reregister=True) | ||
| self.state = KnowledgeBaseState.REGISTERED |
There was a problem hiding this comment.
Wat gebeurt er als register_kb niet succeed/faalt met een exceptie? Wordt de state dan alsnog op REGISTERED gezet?
Contributor
Author
There was a problem hiding this comment.
Als register_kb faalt dan wordt de exceptie doorgegeven en wordt de state niet REGISTERED. Mijn redenering was dat als je KB niet registered dat probleem groot genoeg is om af te breken, en dat de gebruiker zelf de exceptie zal moeten handelen als je bijvoorbeeld een retry of iets dergelijks wilt hebben.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #12
Tests for various (incorrect) scenarios, like KI registration before KB registration, double registration, duplicate names, etc.