Skip to content

perf(generation): index assigned images by id in fixElementDefaults #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyuc merged 2 commits into from
Jun 30, 2026
Merged

perf(generation): index assigned images by id in fixElementDefaults #701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ca517a
perf(generation): index assigned images by id in fixElementDefaults
ly-wang19 Jun 9, 2026
c02b8b2
Merge branch 'main' into perf/scene-generator-image-lookup-map
wyuc Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/generation/scene-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,11 @@ function fixElementDefaults(
elements: GeneratedSlideData['elements'],
assignedImages?: PdfImage[],
): GeneratedSlideData['elements'] {
// Index assigned images by id once (O(m)) so the per-image-element lookup
// below is O(1) instead of a `.find` nested inside this map (which made the
// pass O(elements × images)).
const imageMetaById = new Map((assignedImages ?? []).map((img) => [img.id, img]));

return elements.map((el) => {
// Fix line elements
if (el.type === 'line') {
Expand Down Expand Up @@ -595,7 +600,7 @@ function fixElementDefaults(

// Correct dimensions using known aspect ratio (src is still img_id at this point)
if (assignedImages && typeof imageEl.src === 'string') {
const imgMeta = assignedImages.find((img) => img.id === imageEl.src);
const imgMeta = imageMetaById.get(imageEl.src);
if (imgMeta?.width && imgMeta?.height) {
const knownRatio = imgMeta.width / imgMeta.height;
const curW = (el.width || 400) as number;
Expand Down
Loading