Merged
Conversation
ceyhun-o
changed the title
orderedPreplayParameters parameters to UplynkorderedPreplayParameters to Uplynk
MattiasBuelens
requested changes
Mar 25, 2026
added 8 commits
March 31, 2026 11:52
Member
therama
reviewed
Apr 1, 2026
therama
approved these changes
Apr 1, 2026
Danesz
reviewed
Apr 1, 2026
MattiasBuelens
requested changes
Apr 1, 2026
Member
|
Summary of this PR. Two problems:
Unordered preplay paramsProblem Cause Solution Missing percent encodingProblem Cause Solution |
Contributor
|
Thanks, I've updated the PR description. 🙂 |
MattiasBuelens
approved these changes
Apr 2, 2026
Danesz
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves two problems:
Unordered preplay params
Problem
Generating a URL with the exact same parameters multiple times might result in different URLs
Cause
Preplay parameters were stored in a Dictionary (aka unordered key-value mapping with unique keys). Since a Dictionary does not have an order. It is impossible to guarantee stable URL generation.
Solution
Store parameters in an array which is ordered. And use the order from the array to generate the URLs
Missing percent encoding
Problem
Characters
?,+and,in the querystring are not percent encoded.Cause
queryStrings were generated using manual string manipulation.
Solution
To generate query strings we use a combination of
This PR replaces #109.
To do: