docs: state how each test dataset was changed from its source - #146
Merged
Merged
Conversation
CC BY 4.0 requires indicating whether licensed material was modified. NOTICE credited the Bavaria, Vienna and 3DBAG sources of the test seeds but did not say that each seed was imported into 3DCityDB, cut to a subset of buildings and exported as a PostgreSQL dump. Each entry now carries that statement, with the building count and the unchanged source reference system.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC BY 4.0 requires indicating whether the licensed material was modified.
NOTICEcredited the source of each test seed intestdata/but did not say how the seed differs from it.Each geometry entry now has a
Changes:line: imported into 3DCityDB with citydb-tool, reduced to a subset of buildings, exported as a PostgreSQL dump, coordinates left in the source reference system, no other edits.Building counts are
objectclass_id = 901rows in each seed'slod2.feature; reference systems are from each seed'slod2.database_srs.