Chore/runtime image naming and mounts - #138
Merged
Merged
Conversation
Dockerfile.server built only the server; it now builds the CLI too, so the name no longer describes it. Renamed to Dockerfile.runtime. The published image name is unchanged, so nothing downstream moves. The server service mounted data/ as a whole, which hid the data/tabula baked into the image behind the host's copy. Anything tested there was testing the host's CSVs, so the no-host-mount configuration the image is built for was never exercised by this file. The dataset directories are now mounted individually. Verified: with the old mount the CSVs come from the host; with the new one they come from the image while the host's lod2 tiles still arrive; with no mounts at all the image carries all 20. The service comment described `go run` against the dev image, no separate build target, and data/ being excluded from the image. None of those had been true since the runtime image was added.
The city2tabula-environment service runs bash for interactive CLI use and serves nothing on port 5000, so publishing it only occupied host port 5000. Remove the mapping and the HOST_PORT variable that fed it.
The HTTP service's container becomes city2tabula, matching the other heat-stack services such as buem-gateway, and the interactive CLI shell becomes city2tabula-cli instead of city2tabula-environment. The makefile and setup scripts exec into the new CLI name. city2tabula-server stays as a network alias on tentacron-net so existing TentaCron proxy targets keep resolving until they move to the new name. The published image name is unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.