Repository navigation
chore(environment): name containers after their service - #137
Merged
Merged
Conversation
The city2tabula-environment service runs bash for interactive CLI use and serves nothing on port 5000, so publishing it only occupied host port 5000. Remove the mapping and the HOST_PORT variable that fed it.
The HTTP service's container becomes city2tabula, matching the other heat-stack services such as buem-gateway, and the interactive CLI shell becomes city2tabula-cli instead of city2tabula-environment. The makefile and setup scripts exec into the new CLI name. city2tabula-server stays as a network alias on tentacron-net so existing TentaCron proxy targets keep resolving until they move to the new name. The published image name is unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container names in
environment/http/docker-compose.ymlnow say what each container is, matching the other heat-stack services (buem-gateway,buem-model).city2tabulacity2tabulacity2tabula-servercmd/server)city2tabula-clicity2tabula-clicity2tabula-environmentc2tcity2tabula-dbcity2tabula-dbThe
makefile,setup.ps1andsetup.batexec intocity2tabula-cli. The published imageghcr.io/thd-spatial-ai/city2tabula-server, the binary name and the CI workflow are unchanged.Compatibility alias
city2tabulakeepscity2tabula-serveras a network alias ontentacron-net. TentaCron's proxy targets for runs, buildings, coverage and geometry resolve the old name until its container is recreated with the updated targets. The alias is removed in a follow-up once that has happened.Dev shell host port
The CLI container runs
bashand serves nothing, so its5000:5000mapping only occupied host port 5000. The mapping and theHOST_PORTvariable indocker.envare removed.Verified
docker compose --env-file docker.env config -qpasses.city2tabula,city2tabulahealthy.http://city2tabula-server:5000/api/v1/healthandhttp://city2tabula:5000/api/v1/healthreturn{"status":"ok"}.city2tabula-clicarriesc2tand resolvescity2tabula-db.