Skip to content

fix(gossip): reject EpochSlots with null BitVec bits in sanitize#1565

Open
dymchenkko wants to merge 1 commit into
Syndica:mainfrom
dymchenkko:fix/gossip-bitvec-null-sanitize
Open

fix(gossip): reject EpochSlots with null BitVec bits in sanitize#1565
dymchenkko wants to merge 1 commit into
Syndica:mainfrom
dymchenkko:fix/gossip-bitvec-null-sanitize

Conversation

@dymchenkko

@dymchenkko dymchenkko commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Implementations

  • Null check in Uncompressed.sanitize rejects messages with null bits before they enter the gossip table
  • Made BitVec.deinit null-safe while at it

Ramifications

  • Peer sends one bad EpochSlots packet -> passes sanitize -> sits in table -> panics on eviction. Delayed crash makes it hard to trace back to the incoming message.

Tests

  • Test now verifies sanitize rejects null bits and deinit survives them

Closes #1564

@github-project-automation github-project-automation Bot moved this to 🏗 In progress in Sig Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

gossip: validator panics on EpochSlots with null BitVec

1 participant