[#361] fix: set parameter type in expression builder - #362
Open
brambaud wants to merge 1 commit into
Open
Conversation
When using SQLite with symfony/uid and symfony/doctrine-bridge, the column type of an uuid is BLOB (see https://github.com/symfony/symfony/blob/9ad4353a8cf349c3b431c163af0b1dd9a29c33a2/src/Symfony/Bridge/Doctrine/Types/AbstractUidType.php#L28). Furthermore, the Sylius\Bundle\GridBundle\Doctrine\ORM\ExpressionBuilder used in the EntityFilter does not specify the type of the parameter, thus the inferred type is a string. It implies that when filtering the query we'll compare the string representation of the uuid with its binary representation. Therefore the EntityFilter does not work. Closed Sylius#361
Member
|
Thx a lot (yes, one year later, sorry). First, we need to convert an integer identifier into an Uuid one on a resource of the tests application. Second, there is already an ExpressionBuilderTest that you need to adapt. |
Author
|
Thanks for the reply! I will see how I can organize my time to add tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #361
I'm not sure how you would prefer to test this so I'm all ears 😁
Is it with the
tests/Application?