Stop tracking build artifacts, fix fake-green CI - #1
Open
SuperInstance wants to merge 3 commits into
Open
Conversation
added 3 commits
July 10, 2026 13:14
Remove committed dist/ wheels + sdists and __pycache__/*.pyc from git tracking. .gitignore already covers dist/, __pycache__/, *.pyc, so these are regenerated locally and never re-added.
The test step appended '|| true', masking every test failure and forcing exit 0 (fake-green). Verified locally: a deliberately broken assertion now produces pytest exit code 1; reverted, all 17 pass (exit 0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo was already in good shape — 17/17 real tests, zero external dependencies confirmed, genuinely published on PyPI. Two real hygiene fixes:
dist/*.whl,dist/*.tar.gz, and 7.pycfiles were tracked in git..gitignorealready correctly covers these patterns — the files were just committed before/around when it was added. Removed from tracking (kept on disk locally)..github/workflows/ci-python.yml's test step had|| true, masking any test failure. Removed it — verified via a deliberate-break-then-revert test (broke an assertion, confirmed real exit code 1, reverted, confirmed clean 17/17 pass with exit 0).Investigated but correctly left alone
The GitHub repo description says "<100KB" while the README's own Design Goals table says "< 50 KB total" — these numbers differ, but a full repo-wide grep confirms the README's figure is the only one that exists in tracked files, is internally consistent, and is accurate (real source ~20.2 KB, wheel ~10.3 KB). The "<100KB" figure only exists in the GitHub repo description, which can't be edited via PR — flagged as a follow-up for whoever has repo-settings access, rather than inventing an unnecessary README change.
Verification
pytest: 17/17 passing, independently re-rungit ls-files | grep -E "dist/|__pycache__|\.pyc$": now returns nothing🤖 Generated with a multi-agent hardening pass (opencode/GLM), independently verified before opening this PR.