Improve logging and update dependencies across projects - #141
Conversation
Enhanced logging with structured EventId and event names for better diagnostics in ANT+ libraries. Updated NuGet dependencies (Microsoft.Maui, Microsoft.NET.Test.Sdk), incremented package versions, and revised release notes. No breaking changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves logging across several projects by adopting structured logging with EventIds and EventNames, updates NuGet package dependencies, and bumps version numbers. The review feedback highlights critical performance and robustness concerns regarding blocking USB I/O operations executed within logging statements. Specifically, retrieving the radio's serial number and product description dynamically inside high-frequency message loops or error-handling paths can lead to severe latency and potential crashes. Caching these values during initialization is recommended to resolve these issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Log messages in AntCollection.cs and AntDeviceCollection.cs now include the AntRadio serial number for improved traceability. Also, EventId objects were added to log calls in AntDeviceCollection.cs for consistency.
1 participant
Improve logging and update dependencies across projects
Enhanced logging with structured EventId and event names for better diagnostics in ANT+ libraries. Updated NuGet dependencies (Microsoft.Maui, Microsoft.NET.Test.Sdk), incremented package versions, and revised release notes. No breaking changes.