Handle Unknown Data Pages - #134
Merged
Merged
Conversation
Introduce UnknownDataPageReceived event and OnUnknownDataPageReceived methods to AntDevice, enabling device profiles to notify subscribers when unrecognized data pages are received. Update all relevant Parse methods to use this event instead of direct logging. Refactor CommonDataPages to return a bool for parse success, and update tests to verify event raising and logging. Includes minor test and code cleanups for consistency.
Added UnknownDataPageReceived event to AntDevice for custom/unknown data page handling. Updated NuGet dependencies and incremented package versions. Revised documentation and version history to reflect changes.
There was a problem hiding this comment.
Code Review
This pull request introduces the UnknownDataPageReceived event to the AntDevice class, allowing subscribers to handle unrecognized data pages. It refactors CommonDataPages.ParseCommonDataPage to return a boolean indicating success, updates various device profiles to raise the new event when parsing fails, and adds corresponding unit tests and documentation. The review feedback recommends cloning the dataPage byte array before raising the event to prevent subscribers from modifying the shared buffer, and adding defensive guard checks in ParseCommonDataPage to avoid potential null reference or index out of range exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
API enhancement to support custom/unknown ANT+ data pages and update dependencies.
PR Summary
This pull request adds the UnknownDataPageReceived event to the AntDevice class, enabling applications to handle unknown or custom data pages, and updates related parsing and tests. It also updates NuGet dependencies and documentation.