Fix: (ctrl+)b crash on new profile - #1508
Open
larswijn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pressing b with debug mode enabled (or ctrl+b with debugplus), the game instantly starts a new run. The modded
SMODS.RunSelect.Functions.start_runhas some issues compared to the vanillaGame:start_runimplementation that this PR aims to fix:On a fresh profile, pressing (ctrl+)b caused the new modded RunSelect to crash. I fixed it to fallback to Red Deck and White Stake, like the vanilla version.
While in the vanilla run select screen, pressing (ctrl+)b starts a run with the currently viewed deck. I modified the new modded RunSelect to also respect the currently viewed deck and stake.
What I have NOT fixed/changed but did notice:
Pressing (ctrl+)b while in a challenge run resets to an "empty" challenge deck on vanilla, and resets to red deck with RunSelect. Both of these are unexpected.
Additional Info: