Skip to content

Comments

FU-P14-T5-1: Add macOS CI execution for broker socket-path regression coverage#97

Merged
SoundBlaster merged 7 commits intomainfrom
feature/FU-P14-T5-1-macos-ci-socket-regression
Feb 20, 2026
Merged

FU-P14-T5-1: Add macOS CI execution for broker socket-path regression coverage#97
SoundBlaster merged 7 commits intomainfrom
feature/FU-P14-T5-1-macos-ci-socket-regression

Conversation

@SoundBlaster
Copy link
Owner

Description

Add explicit macOS CI coverage for the broker AF_UNIX socket-path regression by introducing a dedicated GitHub Actions job:

  • test-macos-socket-regression on macos-latest
  • Runs TestSocketPermissions::test_socket_created_with_0600_permissions
  • Includes inline workflow note explaining the macOS-specific AF_UNIX path-length rationale

This keeps the existing Ubuntu test matrix unchanged.

Also includes full FLOW artifacts for FU-P14-T5-1 (plan, validation, review, archive updates).

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • CI/CD improvement

Quality Gates

Before submitting, ensure all quality gates pass:

make check

Or run individually:

  • make test - All tests pass with ≥90% coverage
  • make lint - No linting errors
  • make format - Code is properly formatted
  • make typecheck - Type checking passes
  • make doccheck - Documentation is synced with DocC (if docs changed)

Documentation Sync

If you modified files in docs/, ensure corresponding DocC files are also updated:

docs/ file DocC file
docs/installation.md mcpbridge-wrapper.docc/Installation.md
docs/cursor-setup.md mcpbridge-wrapper.docc/CursorSetup.md
docs/claude-setup.md mcpbridge-wrapper.docc/ClaudeCodeSetup.md
docs/codex-setup.md mcpbridge-wrapper.docc/CodexCLISetup.md
docs/troubleshooting.md mcpbridge-wrapper.docc/Troubleshooting.md
docs/architecture.md mcpbridge-wrapper.docc/Architecture.md
docs/environment-variables.md mcpbridge-wrapper.docc/EnvironmentVariables.md
README.md mcpbridge-wrapper.docc/mcpbridge-wrapper.md
  • Documentation changes are synced with DocC catalog (or N/A)

Testing

  • Added/updated tests for new functionality
  • All tests pass locally
  • Manually tested the changes

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • Comments added for complex code
  • Documentation updated (if needed)
  • No new warnings generated
  • PR title is descriptive

Validation Report

  • SPECS/ARCHIVE/FU-P14-T5-1_Add_macos_CI_execution_for_broker_socket-path_regression_coverage/FU-P14-T5-1_Validation_Report.md

Review

  • Review found no actionable issues; FOLLOW-UP step skipped per FLOW.

@SoundBlaster SoundBlaster merged commit 2c4f94c into main Feb 20, 2026
10 checks passed
@SoundBlaster SoundBlaster deleted the feature/FU-P14-T5-1-macos-ci-socket-regression branch February 20, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant