fix: remove stale 'GitHub Check Run upload' from session-review description#42
Merged
Conversation
…ring
Root causes of ci-verify-local.yml always failing:
1. Check Runs API requires a GitHub App token (checks:write) — a regular PAT
always gets 403. Replaced with Commit Status API (POST /statuses/{sha})
which works with any repo-scoped PAT, no GitHub App needed.
2. Upload was called in /session-end before the commit existed, posting the
status on the wrong (previous) commit SHA.
3. Even the PR comment fallback missed because CI fires on pr:opened before
the upload had a chance to run.
Fix:
- upload-test-results.sh: POST to /statuses/{sha} instead of /check-runs
- ci-verify-local.yml: check commit status instead of Check Runs (Option 1)
- session-end SKILL.md: remove premature upload step (wrong SHA), add
post-commit callout: run upload after push, before creating PR
- Docs (CLAUDE.md, CONTRIBUTING.md, README.md, PR template): correct
ordering and wording throughout
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Local tests not yet uploadedThis repository runs macOS-dependent tests locally (not in CI) to keep
Results will appear either as a Check Run or a PR comment on this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session-reviewskill description — the upload step was moved out of the skill in PR fix: pin security-reviewer to sonnet, explicit model fields, drift test #39 (the upload now runs manually after push, before PR creation, to ensure the correct commit SHA is posted)Type of change
Context
PR #39 merged the full
claude/wizardly-kalambranch, which included both commits:afc3d74— agent model fields + drift teste4e4990— Commit Status API fix + session workflow orderingAll the code changes landed correctly. This PR fixes the one remaining doc drift: the
session-reviewskill description still listed "GitHub Check Run upload" as a pipeline step, but the skill body correctly says the upload runs AFTER commit+push (not inside the skill). The description now matches the implementation.Testing checklist
make test-docs— 17/18 pass (1 pre-existing failure:skills/customize-buddymissing SKILL.md, not introduced here — exists on main)Risk
Description-only change. No behavior change.
🤖 Generated with Claude Code