Fix journalctl JSON parsing for byte-array MESSAGE fields#616
Open
sfc-gh-mjankowski wants to merge 1 commit intomainfrom
Open
Fix journalctl JSON parsing for byte-array MESSAGE fields#616sfc-gh-mjankowski wants to merge 1 commit intomainfrom
sfc-gh-mjankowski wants to merge 1 commit intomainfrom
Conversation
sfc-gh-mjankowski
force-pushed
the
mjankowski-improve-journalctl-json-parsing
branch
from
c735b69 to
c1bba96
Compare
sfc-gh-mjankowski
force-pushed
the
mjankowski-improve-journalctl-json-parsing
branch
from
c1bba96 to
5dbb798
Compare
sfc-gh-ikryvanos
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json: cannot unmarshal array into Go value of type stringwhenjournalctl --output=jsonencodes binary/non-UTF8 fields (e.g. MESSAGE) as byte arrays instead of stringsmap[string]stringtomap[string]any, convert values back to strings with non-printable character sanitizationTest plan
TestJournalByteArrayRegressionproves the old code fails and the new code succeedsTestJournalValueToStringcovers: string passthrough, valid byte arrays, non-printable sanitization, high bytes, boundary values, invalid arrays (mixed types, out-of-range), unexpected JSON typesTestSanitizeStringcovers: printable ASCII, whitespace preservation, control chars, invalid UTF-8, multibyteTestJournalEntryToStringMapcovers: mixed types, empty map, multiple byte-array fields, JSON number valuesTestJournalByteArrayMessageend-to-end through gRPC server (raw + structured modes)TestJournalcases still pass (no regression on normal string entries)