Skip to content

Implement AuditScope extension for Scope#123

Merged
s-vitaliy merged 3 commits into
mainfrom
add-audited-pipeline
Jun 23, 2026
Merged

Implement AuditScope extension for Scope#123
s-vitaliy merged 3 commits into
mainfrom
add-audited-pipeline

Conversation

@s-vitaliy

@s-vitaliy s-vitaliy commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Part of #71
Also related to #70

Scope

Implemented:

  • Implemented AuditScope - an extension method that allows define an initial audit scope for the token endpoint.
  • Added integration tests for the audit middlewares.

Additional changes:

  • Moved extract_external_token to one level up.
  • Updated docstring in the project

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner June 22, 2026 14:15
@github-actions

Copy link
Copy Markdown

Coverage after merging add-audited-pipeline into main will be

81.15%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/contracts/internal_token/v1
   boxer_claims.rs100%100%100%100%
   token.rs100%100%100%100%
src/contracts/internal_token/v1/boxer_claims
   tests.rs100%100%100%100%
src/contracts/internal_token/v1/token
   tests.rs100%100%100%100%
src/contracts/internal_token/v2
   boxer_claims.rs100%100%100%100%
   internal_token.rs0%100%0%0%31–54, 60–69, 71–72, 74–77
src/contracts/internal_token/v2/boxer_claims
   tests.rs98.92%100%100%98.75%53
src/contracts/internal_token/v2/internal_token
   tests.rs100%100%100%100%
src/http
   readiness.rs96.55%100%100%95.83%42
src/http/extractors
   boxer_claims.rs0%100%0%0%10–13, 15–17
src/http/middleware
   extract_external_token.rs100%100%100%100%
   tracer.rs0%100%0%0%30–37
src/http/middleware/audit
   audit_recorder.rs96.55%100%100%96.15%
   audit_scope.rs100%100%100%100%
   audited_error.rs80%100%66.67%81.25%117, 123–124, 133–135, 140–142, 80, 89–90
   audited_request.rs69.23%100%66.67%69.57%121, 129, 48–51, 53, 64–70
   audited_response.rs86.36%100%100%84.21%32–34
   begin_audit_chain.rs100%100%100%100%
   tests.rs63.89%100%50%69.23%120, 164, 178, 20, 70
src/http/middleware/audit/audit_recorder
   audit_recorder_factory.rs100%100%100%100%
   tests.rs72.31%100%60%77.78%121, 143, 151, 71, 96
src/http/middleware/audit/audited_error
   tests.rs100%100%100%100%
src/http/middleware/audit/audited_request
   tests.rs100%100%100%100%
src/http/middleware/audit/begin_audit_chain
   tests.rs80%100%80%80%38
src/http/middleware/tracer
   tracer_middleware_factory.rs0%100%0%0%15–17, 32–41
src/models
   external_token.rs96.30%100%100%95.65%47
src/models/external_token
   tests.rs100%100%100%100%
src/services/audit
   audit_facade.rs100%100%100%100%
   log_audit_service.rs0%100%0%0%13–15
src/services/audit/audit_facade
   tests.rs98.48%100%95.45%99.09%
   to_audit_record.rs50%100%50%50%6–8
src/services/audit/chained
   audit_event.rs100%100%100%100%
   chained_audit_event.rs100%100%100%100%
   token_audit_event.rs68.18%100%66.67%68.42%37–42
src/services/audit/events
   authorization_audit_event.rs0%100%0%0%21, 23–24, 26, 30–38, 40–42
   resource_delete_audit_event.rs100%100%100%100%
   resource_modification_audit_event.rs100%100%100%100%
   token_validation_event.rs0%100%0%0%23–32, 34–36, 38–42, 44, 46–54, 64–66, 68, 70
src/services/backends
   memory.rs0%100%0%0%19–23, 25, 36–40, 42–45, 56–60
src/services/backends/kubernetes
   kubeconfig_loader.rs0%100%0%0%10–12, 14–16, 18–20, 38–42, 44, 46–51, 60–66, 72–76
   kubernetes_repository.rs59%100%44.44%60.44%118, 123, 125–127, 129, 131–132, 161, 166, 169, 174, 180, 182–183, 187, 43–49, 51–53, 55–57, 61–65
   kubernetes_resource_manager.rs90.65%100%84.62%91.49%175–176, 187–191
   logging_update_handler.rs85.71%100%100%84.62%24–25
src/services/backends/kubernetes/kubernetes_repository
   schema_repository.rs62.86%100%28.57%71.43%54–57
   tests.rs100%100%100%100%
   to_resource.rs100%100%100%100%
   try_into_object_ref.rs62.50%100%50%64.29%39–43
src/services/backends/kubernetes/kubernetes_repository/schema_repository
   schema_document.rs93.75%100%85.71%96%
   test_reduced_schema.rs100%100%100%100%
   test_schema.rs100%100%100%100%
   tests.rs100%100%100%100%
src/services/backends/kubernetes/kubernetes_resource_manager
   object_owner_mark.rs100%100%100%100%
   status.rs44.44%100%50%43.48%27, 33–36, 38, 42–44, 52, 54–56
   tests.rs100%100%100%100%
src/services/backends/kubernetes/kubernetes_resource_manager/object_owner_mark
   tests.rs100%100%100%100%
src/services/backends/kubernetes/kubernetes_resource_manager/status
   not_found_details.rs100%100%100%100%
   owner_conflict_details.rs100%100%100%100%
src/services/observability
   composed_logger.rs68.63%100%75%67.44%30–31, 33–35, 37–40, 65–69
src/services/observability/composed_logger
   tests.rs97.47%100%90%98.55%36
src/services/observability/open_telemetry/metrics
   into_metric_tag.rs0%100%0%0%10, 8–9

@s-vitaliy s-vitaliy requested review from timonviola and removed request for george-zubrienko June 23, 2026 08:05
@s-vitaliy s-vitaliy merged commit 3fa7014 into main Jun 23, 2026
1 check passed
@s-vitaliy s-vitaliy deleted the add-audited-pipeline branch June 23, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants