feat(helm): gate operator/webhook PDBs on HA and expose maxUnavailable#178
Open
giuliocalzo wants to merge 1 commit into
Open
feat(helm): gate operator/webhook PDBs on HA and expose maxUnavailable#178giuliocalzo wants to merge 1 commit into
giuliocalzo wants to merge 1 commit into
Conversation
Skip rendering the operator and webhook PodDisruptionBudgets when `replicas <= 1` since a PDB covering a single-replica Deployment blocks voluntary evictions. Expose `maxUnavailable` alongside `minAvailable` in values, defaulting `maxUnavailable` to 1 when neither is explicitly set. Drop the `unhealthyPodEvictionPolicy` knob to keep the surface small. Helm unit tests updated accordingly, including a case that verifies no PDB is rendered when running a single replica.
giuliocalzo
requested review from
SkylerMalinowski,
alanmutsch,
catblade,
vivian-hafener and
wickberg
as code owners
vivian-hafener
removed request for
SkylerMalinowski,
alanmutsch,
catblade and
wickberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PodDisruptionBudgetwhenreplicas <= 1inhelm/slurm-operator. A PDB in front of a single-replica Deployment would block voluntary evictions (drains, node upgrades) without providing any availability benefit.maxUnavailablealongsideminAvailableinvalues.yamlfor bothoperator.pdbandwebhook.pdb. When neither is explicitly set, templates default tomaxUnavailable: 1. When both are set, both are rendered. When onlyminAvailableis set, onlyminAvailableis rendered.unhealthyPodEvictionPolicyknob to keep the values surface small and focused.Test plan
helm unittest helm/slurm-operator -f 'tests/operator_pdb_test.yaml' -f 'tests/webhook_pdb_test.yaml'passes (18 tests), including new cases:replicas: 1minAvailableandmaxUnavailableare rendered when both are setmaxUnavailabledefaults to 1 when neither is setmaxUnavailableis rendered whenminAvailableis unset