ENH: Convert pctpairprotonsLomaLinda to Python application#1
Closed
acoussat wants to merge 3 commits intoSimonRit:LMU_HeCTfrom
Closed
ENH: Convert pctpairprotonsLomaLinda to Python application#1acoussat wants to merge 3 commits intoSimonRit:LMU_HeCTfrom
pctpairprotonsLomaLinda to Python application#1acoussat wants to merge 3 commits intoSimonRit:LMU_HeCTfrom
Conversation
acoussat
commented
Apr 15, 2026
|
|
||
| def test_lomalinda_application(tmp_path, lomalinda_data): | ||
| output = tmp_path / "lomalinda.mhd" | ||
| pct.pctlomalinda( |
Author
There was a problem hiding this comment.
Currently does not work because of old PCT version. Should work once RTKConsortium#41 is rebased onto main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to add an automatic test that fetches the example file we have and run
pctlomalindaandpctfilterprotonson it, but I struggle to understand how to proceed. It looks like some RTK mechanisms to test Python examples are still missing on PCT side. @axel-grc perhaps you could help me with that?