Skip to content

[BUG FIX] [MER-5780] Add accessible titles and descriptions to adaptive iframes#6734

Merged
darrensiegel merged 2 commits into
masterfrom
MER-5780
Jul 18, 2026
Merged

[BUG FIX] [MER-5780] Add accessible titles and descriptions to adaptive iframes#6734
darrensiegel merged 2 commits into
masterfrom
MER-5780

Conversation

@kjsegovi

@kjsegovi kjsegovi commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

This is a fix for MER-5780. I am adding an aria label to the iframe component in Advanced Author and Simple Author. The previously set description should also still be available and continue being announced.

  • Adds a separate, editable Title field to the iframe component in Simple Author and Advanced Author.
  • Defaults missing or blank iframe titles to Embedded content, including existing content.
  • Preserves the existing Description field and uses it as the iframe’s accessible description.
  • Associates descriptions through a dedicated aria-describedby target.
  • Removes the redundant aria-label and the previous container-level description association that caused repeated and unrelated screen-reader announcements.
  • Requires no content or database migration.

Testing

Automated

  • 43 related Jest tests pass.
  • TypeScript check passes.
  • ESLint passes.
  • Prettier passes.
  • Git diff check passes.

Manual

Verified in authoring and delivery that:

  • Title and Description are separate editable fields.
  • Custom values persist after saving and refreshing.
  • Existing iframe descriptions remain available.
  • Missing titles use Embedded content.
  • Empty descriptions do not add aria-describedby.
  • VoiceOver announces the title once, followed by the description.
  • Surrounding screen titles are no longer included in the iframe announcement.
  • External iframe content continues to load and scroll normally.

@github-actions

Copy link
Copy Markdown
Contributor

Risk score: 2 → risk/low

Generated by 🚫 dangerJS against c787acc

@github-actions

Copy link
Copy Markdown
Contributor

AI Review — security

No issues found

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

AI Review — ui

Preserve the description fallback

file: assets/src/components/parts/janus-capi-iframe/ExternalActivity.tsx
line: 1229
Description: The previous implementation fell back to description when formattedDescription was empty. Resolving only formattedDescription can now omit accessible context despite a model description being available.
Suggestion: Use resolveIframeDescription(formattedDescription || description).

@github-actions

Copy link
Copy Markdown
Contributor

AI Review — typescript

No issues found

@darrensiegel
darrensiegel merged commit bf33610 into master Jul 18, 2026
21 checks passed
@darrensiegel
darrensiegel deleted the MER-5780 branch July 18, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants