Skip to content

[ENHANCEMENT] [MER-5416] Add workflow-based mixed page authoring coverage - PART 1/2#6732

Open
nicocirio wants to merge 6 commits into
masterfrom
MER-5416-automated-basic-page-authored
Open

[ENHANCEMENT] [MER-5416] Add workflow-based mixed page authoring coverage - PART 1/2#6732
nicocirio wants to merge 6 commits into
masterfrom
MER-5416-automated-basic-page-authored

Conversation

@nicocirio

Copy link
Copy Markdown
Contributor

Jira

https://eliterate.atlassian.net/browse/MER-5416

Summary

  • add a reusable workflow runner for automation that alternates scenario setup/assertions with Playwright actions
  • document the workflow contract and add a row-complete mixed coverage matrix for the MIXED spreadsheet tab
  • add initial mixed workflow coverage for code block and callout, including author preview and published delivery assertions
  • keep this PR intentionally limited to the foundational workflow infrastructure plus the first representative mixed-content slice

Implementation Notes

  • runWorkflow(...) is additive and does not replace seedScenario(...)
  • this PR is foundational: it extends the automation stack to support multi-step scenario/playwright workflows
  • the first coverage slice is intentionally limited to CODEBLOCK and CALLOUT
  • the remaining rows tracked in mixed_coverage_matrix.md are expected to land in follow-up PRs
  • the goal is to avoid one oversized PR and prove the workflow pattern before expanding across the rest of the matrix
  • mixed workflow assertions rebuild context in Elixir hooks and validate both author preview and published delivery content

Validation

  • mix format
  • mix compile
  • yarn --cwd assets run format
  • yarn --cwd assets run check-types
  • yarn --cwd assets run deploy
  • npx playwright test tests/torus/course_authoring/mixed-workflow.spec.ts --reporter=line
  • mix test

@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️ PR is large (2440 LOC changed). Consider splitting.

Risk score: 5 → risk/medium

Generated by 🚫 dangerJS against 2bf3744

@github-actions

Copy link
Copy Markdown
Contributor

AI Review — security

No issues found

@github-actions

Copy link
Copy Markdown
Contributor

AI Review — performance

No issues found

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

AI Review — elixir

Assertions do not verify the content type

file: lib/oli/scenarios/features/mixed_content_hooks.ex
line: 78
Description: Searching every nested value can pass when the expected text appears elsewhere, without confirming a code block or callout was published correctly.
Suggestion: Locate the content node by its block type, then assert the expected caption, code, or callout field directly.

@nicocirio nicocirio changed the title [FEATURE] [MER-5416] Add workflow-based mixed page authoring coverage [ENHANCEMENT] [MER-5416] Add workflow-based mixed page authoring coverage - PART 1/2 Jul 16, 2026
@nicocirio
nicocirio marked this pull request as ready for review July 16, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant