Conversation
Implement core refactor
* docs refactor * docs * implement tool deep linking
* implement full nrps support * run ci * ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds full tool-side NRPS support on top of the core and deep-linking work. It introduces typed NRPS endpoint
parsing, scope enforcement, pagination traversal, filter normalization, structured errors, telemetry, and both
streaming and eager roster retrieval APIs.
This PR should be reviewed and landed after #43
What Changed
Lti_1p3.Tool.Services.NRPS.from_launch_claim/1Lti_1p3.Tool.Services.NRPS.list_memberships/3Lti_1p3.Tool.Services.NRPS.stream_memberships/3Lti_1p3.Tool.Services.NRPS.fetch_all_memberships/3fetch_memberships/2through the stricter NRPS pipeline while preserving its legacy tuple shapeLti_1p3.Services.HTTP.LinkHeaderLti_1p3.Services.HTTP.QueryFiltersWhy
The previous implementation was single-page oriented and too loose around scopes, filters, and failure semantics. This
PR makes NRPS usable for production roster retrieval and establishes shared HTTP utilities needed by later service
work.
Reviewer Notes
Focus review on:
Linkheader traversalfetch_memberships/2Most of the cumulative diff is inherited from PRs 1 and 2. The incremental review surface is the NRPS modules plus the
shared HTTP paging/filter helpers.
Documentation
docs/tool_nrps_guide.mddocs/features/tool-nrps/*README.mdCHANGELOG.md