Repository navigation
Conversation
The 202 for a code send carries `delivery_mode`, `own` or `sandbox`. A keyed send stores the mode with its idempotency record, so a replay answers with the first send's mode, even when the default sender changed in between. A record without a stored mode replays without the field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#584 folded the keyed replay tests into one parameterized test; the merge keeps that shape and adds this part's delivery_mode assertions to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of map #461 (sandbox sender for API sends). SA1 part 3 of 3, split from #632: the
delivery_modeanswer. Stacked on #637 (part 2), on #636 (part 1). #633 sits on top.Problem
Merge Danger
Note
🟡 Merge risk: medium · two-way door: a revert drops the field from the 202
delivery_mode: own, and nothing else about it changes.Changes
delivery_mode,ownorsandbox.How did you test this code?
Test seams: the cdp-api code-send route over HTTP (
cdp-api.serial.test.ts).Test rationale: the mode on own and sandbox sends, and a keyed replay after the default sender changed.
Proofs:
CI: this PR sits on an integration base until the sandbox stack (through #587) and the send stacks (through #584 and #585) reach master.
Release status
Docs update
docs/internal/workflows-email-sending-tiers.mdis updated in feat(messaging): send code emails through the sandbox sender without a domain #633.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Claude Opus 5.5 (claude-opus-5-5)
Skills:
/tdd,/writing-tests,/qa-swarm,/pr-description,/writing-pr-descriptionsdelivery_modeInvolvement: the SA1 review carries over from #632, whose code these three parts hold: one design pass, a 7-lens security swarm, a 4-lens fix round and one clean final read (GPT-6.1 Sol and Claude Opus 5.5). One GPT-6.1 Sol read of this part came back clean. A GPT-6.1 Sol read of the merge that took the newer base came back clean.
More context for AI agents
sbx-apiof map Map: send code-managed email templates with one PostHog call #461, Claude Code.87af9d607ca; this head's tree is the same.idempotency-keys.tsand the replay branch incdp-api.ts.🤖 Generated with Claude Code