Skip to content

fix: pre-warm wiki index on service worker startup; fix iOS UI navigation delegate (v2.3.0)#22

Merged
kiyarose merged 3 commits intomainfrom
copilot/investigate-flean-ui-redirect-issue
Apr 12, 2026
Merged

fix: pre-warm wiki index on service worker startup; fix iOS UI navigation delegate (v2.3.0)#22
kiyarose merged 3 commits intomainfrom
copilot/investigate-flean-ui-redirect-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 12, 2026

  • JS-0116: Remove async from warmIndex() in both wiki-data-manager.js files (function returns a Promise directly, no await needed)
  • SW-W1023: Replace Bundle.main.resourceURL! force-unwrap with a safe let resourceURL = Bundle.main.resourceURL binding in WebViewContainer.swift
  • SW-W1022: Change WKNavigation! to WKNavigation? in the didFinish delegate method signature

…e, bump to 2.3.0

Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/85ef0bde-c484-413d-b06a-3f226ff8c228

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
@kiyarose kiyarose marked this pull request as ready for review April 12, 2026 12:01
Copilot AI review requested due to automatic review settings April 12, 2026 12:01
This commit fixes the style issues introduced in f654093 according to the output
from PHP CS Fixer, StandardJS and swift-format.

Details: #22
@kiyarose kiyarose marked this pull request as draft April 12, 2026 12:01
@kiyarose kiyarose marked this pull request as ready for review April 12, 2026 12:01
@deepsource-io
Copy link
Copy Markdown

deepsource-io bot commented Apr 12, 2026

DeepSource Code Review

We reviewed changes in a70cbb7...548b3f5 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Apr 12, 2026 12:09p.m. Review ↗
Shell Apr 12, 2026 12:09p.m. Review ↗
JavaScript Apr 12, 2026 12:09p.m. Review ↗
Swift Apr 12, 2026 12:09p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

This comment was marked as outdated.

…unwrap resourceURL, use optional WKNavigation

Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/649826ec-06e9-407d-b1e4-56c99779f8cc

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Copilot AI requested a review from kiyarose April 12, 2026 12:09
@kiyarose kiyarose enabled auto-merge April 12, 2026 12:10
@kiyarose kiyarose merged commit f6ff57e into main Apr 12, 2026
7 checks passed
@kiyarose kiyarose deleted the copilot/investigate-flean-ui-redirect-issue branch April 12, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants