feat: Properly Redirect Indie Wikies to specific pages#19
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Apr 12, 2026 3:51a.m. | Review ↗ | |
| Shell | Apr 12, 2026 3:51a.m. | Review ↗ | |
| JavaScript | Apr 12, 2026 3:51a.m. | Review ↗ | |
| Swift | Apr 12, 2026 3:51a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
…on to 2.2.0 Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/03459e09-3dc2-45d6-bf14-d042a1a05ac8 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/03459e09-3dc2-45d6-bf14-d042a1a05ac8 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
|
@codex review |
|
@codex[agent] review |
Reviewed the changes—no issues found in the new article path handling or main-page fallback logic; no further edits needed. Tests not run in this pass. |
|
To use Codex here, create a Codex account and connect to github. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
Updates the app/extension version numbers and adjusts wiki destination URL building to better handle main-page redirects and non-templated destination paths.
Changes:
- Bumped
MARKETING_VERSIONto2.2.0andCURRENT_PROJECT_VERSIONto4in both macOS and iOS Xcode projects. - Bumped extension
manifest.jsonversions to2.2.0(macOS + iOS bundles). - Enhanced
findMatchingWiki()URL construction to (a) map wiki-root / origin-main-page visits to a destination main page when provided, and (b) support destination content paths that are either$1-templated or prefix-style.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
mos/Flean.xcodeproj/project.pbxproj |
Version/build number bump for macOS targets. |
mos/Flean Extension/Resources/scripts/wiki-data-manager.js |
Improves destination URL generation and main-page handling. |
mos/Flean Extension/Resources/manifest.json |
Extension version bump to 2.2.0. |
ios/Flean.xcodeproj/project.pbxproj |
Version/build number bump for iOS targets. |
ios/extention/Resources/scripts/wiki-data-manager.js |
Mirrors the macOS URL-generation improvements for iOS extension bundle. |
ios/extention/Resources/manifest.json |
Extension version bump to 2.2.0. |
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/0c143699-654f-4f72-a71f-47df14596945 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
…swift Add Swift CodeQL workflow and fix Dependabot config
Redirects to independent wikis always landed on the wiki root instead of the specific article. The IWB data uses plain prefixes (e.g.
/wiki/) fordestination_content_pathno$1placeholder, so.replace(‘$1’, articlewas a no-op on every match