Skip to content

feat: Properly Redirect Indie Wikies to specific pages#19

Merged
kiyarose merged 5 commits intomainfrom
copilot/feat-preserve-formatting-indep-wikis
Apr 12, 2026
Merged

feat: Properly Redirect Indie Wikies to specific pages#19
kiyarose merged 5 commits intomainfrom
copilot/feat-preserve-formatting-indep-wikis

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 12, 2026

Redirects to independent wikis always landed on the wiki root instead of the specific article. The IWB data uses plain prefixes (e.g. /wiki/) for destination_content_path no $1 placeholder, so .replace(‘$1’, article was a no-op on every match

// Before — $1 not present, replace() is a no-op → always "/wiki/"
destPath = wiki.destination_content_path.replace('$1', encodedArticle)

// After
if (wiki.destination_content_path.includes('$1')) {
  destPath = wiki.destination_content_path.replace('$1', encodedArticle)
} else {
  destPath = wiki.destination_content_path + encodedArticle
}

Copilot AI linked an issue Apr 12, 2026 that may be closed by this pull request
@deepsource-io
Copy link
Copy Markdown

deepsource-io bot commented Apr 12, 2026

DeepSource Code Review

We reviewed changes in e09b771...f78d5a4 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Apr 12, 2026 3:51a.m. Review ↗
Shell Apr 12, 2026 3:51a.m. Review ↗
JavaScript Apr 12, 2026 3:51a.m. Review ↗
Swift Apr 12, 2026 3:51a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copilot AI and others added 2 commits April 12, 2026 03:30
Copilot AI changed the title [WIP] Add functionality to preserve formatting on independent wikis feat: preserve article path when redirecting to independent wikis (v2.2.0) Apr 12, 2026
Copilot AI requested a review from kiyarose April 12, 2026 03:32
@kiyarose
Copy link
Copy Markdown
Member

@codex review

@kiyarose
Copy link
Copy Markdown
Member

@codex[agent] review

@Codex
Copy link
Copy Markdown

Codex AI commented Apr 12, 2026

@codex[agent] review

Reviewed the changes—no issues found in the new article path handling or main-page fallback logic; no further edits needed. Tests not run in this pass.

@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@Codex Codex AI changed the title feat: preserve article path when redirecting to independent wikis (v2.2.0) Addressing PR comments Apr 12, 2026
@kiyarose kiyarose marked this pull request as ready for review April 12, 2026 03:38
Copilot AI review requested due to automatic review settings April 12, 2026 03:38
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the app/extension version numbers and adjusts wiki destination URL building to better handle main-page redirects and non-templated destination paths.

Changes:

  • Bumped MARKETING_VERSION to 2.2.0 and CURRENT_PROJECT_VERSION to 4 in both macOS and iOS Xcode projects.
  • Bumped extension manifest.json versions to 2.2.0 (macOS + iOS bundles).
  • Enhanced findMatchingWiki() URL construction to (a) map wiki-root / origin-main-page visits to a destination main page when provided, and (b) support destination content paths that are either $1-templated or prefix-style.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mos/Flean.xcodeproj/project.pbxproj Version/build number bump for macOS targets.
mos/Flean Extension/Resources/scripts/wiki-data-manager.js Improves destination URL generation and main-page handling.
mos/Flean Extension/Resources/manifest.json Extension version bump to 2.2.0.
ios/Flean.xcodeproj/project.pbxproj Version/build number bump for iOS targets.
ios/extention/Resources/scripts/wiki-data-manager.js Mirrors the macOS URL-generation improvements for iOS extension bundle.
ios/extention/Resources/manifest.json Extension version bump to 2.2.0.

@kiyarose kiyarose changed the title Addressing PR comments feat: Properly Redirect Indie Wikies to specific pages Apr 12, 2026
@kiyarose kiyarose enabled auto-merge April 12, 2026 03:47
…swift

Add Swift CodeQL workflow and fix Dependabot config
@kiyarose kiyarose merged commit dda83cf into main Apr 12, 2026
8 checks passed
@kiyarose kiyarose deleted the copilot/feat-preserve-formatting-indep-wikis branch April 12, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: preserve formatting on independent wikis

4 participants