Fix two ImportExportCost defects on Source - #242
Merged
Conversation
Skip the unoffered side. The `isnothing(get_output_offer_curves(...))` guards were dead: psy6 PSY defaults both offer curves to ZERO_OFFER_CURVE rather than nothing, so a one-directional source got a block of PWL variables, a linking constraint and objective terms priced at zero for the side it does not offer. `IOM.is_nontrivial_offer` is the check the Storage sibling forty lines below already used, and it handles the time-series-backed case too, so the FIXME's stated blocker no longer held. The CATS import sources are import-only and hit this. Fix ImportExportBudgetConstraint under sub-hourly resolution. `Dates.Hour(resolution).value` throws InexactError for any resolution that is not a whole number of hours -- Settings normalises resolution to Milliseconds, so a 5-minute model could not build the constraint at all. Uses `Dates.value(resolution) / MILLISECONDS_IN_HOUR`, matching the four other conversions in the codebase. Each test fails without its own fix.
|
Performance Results
|
luke-kiernan
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.