fix(tmdb): skip the animation genre requirement for restricted auto-match - #1391
Draft
Foowy wants to merge 1 commit into
Draft
fix(tmdb): skip the animation genre requirement for restricted auto-match#1391Foowy wants to merge 1 commit into
Foowy wants to merge 1 commit into
Conversation
Foowy
force-pushed
the
fix/tmdb-restricted-genre-filter
branch
3 times, most recently
from
July 29, 2026 14:53
8f85c65 to
6843fd4
Compare
Foowy
force-pushed
the
fix/tmdb-restricted-genre-filter
branch
4 times, most recently
from
August 10, 2026 00:46
dec0a84 to
efcf05a
Compare
Foowy
force-pushed
the
fix/tmdb-restricted-genre-filter
branch
from
August 13, 2026 17:18
efcf05a to
1467c93
Compare
Foowy
marked this pull request as draft
August 16, 2026 09:17
Contributor
Author
|
Placing into draft pending updated TMDBLib |
Foowy
force-pushed
the
fix/tmdb-restricted-genre-filter
branch
2 times, most recently
from
August 23, 2026 16:25
54d6c6d to
d830597
Compare
Foowy
force-pushed
the
fix/tmdb-restricted-genre-filter
branch
from
August 25, 2026 13:08
d830597 to
fe47cf2
Compare
…atch `CollectCandidates`/`CollectMovieCandidates` required every TMDB search hit to carry the "animation" genre tag before it was even considered a candidate. TMDB's genre metadata is community-maintained and disproportionately sparse for R18/adult content, so a correct match was often discarded before scoring ever ran, making restricted auto-match appear broken. Threads the existing `includeRestricted`/`restricted` flag (already available at every call site) into both helpers and skips the genre check only when the anime is restricted — non-restricted search keeps the same guard against unrelated live-action/non-anime hits. The downstream title/date scoring (`IsAcceptableAutoMatch` rejecting `FirstAvailable`) still prevents a genuinely unrelated candidate from being accepted.
Foowy
force-pushed
the
fix/tmdb-restricted-genre-filter
branch
from
September 5, 2026 23:25
fe47cf2 to
b026a2b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CollectCandidates/CollectMovieCandidatesrequired every TMDB search hit to carry the "animation" genre tag before it was even considered a candidate. TMDB's genre metadata is sparse for R18/adult content, so a correct match was often discarded before scoring ran.includeRestricted/restrictedflag into both helpers and skips the genre check only when the anime is restricted — non-restricted search keeps the guard against unrelated live-action hits.Draft — pending an update to TMDbLib.
Test plan
dotnet build Shoko.Server.slndotnet test Shoko.Tests/Shoko.Tests.csproj --filter "FullyQualifiedName~TmdbSearchServiceTests"(32/32 passing, including 4 new tests for the genre-bypass behavior)Rebase history
upstream/master@b6fdba59b(1 commits), now atd830597e9upstream/master@33d8271e4(1 commits), now atb026a2b77