Fix attempt for issue #1228#1243
Closed
BennyyyBB wants to merge 5 commits into
Closed
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The user described a bug (issue #1228) that caused the mention/reply sound to not play and automatically reset in the settings. Having a look at the codes I figured out that the built-in mention/reply highlights are being edited through the custom-highlight UI even though they are intentionally non-persistent. Therefore I fixed two main things:
Types of changes
Checklist
Further notes
Since these changes are only an attempt to fully fix the bug, some further code adjustments might need to be made. Feel free to suggest improvements.