Skip to content

Kernel/x86_64: Fix booting with time=legacy#26840

Merged
spholz merged 2 commits into
SerenityOS:masterfrom
LucasChollet:rtc-fix
Jul 4, 2026
Merged

Kernel/x86_64: Fix booting with time=legacy#26840
spholz merged 2 commits into
SerenityOS:masterfrom
LucasChollet:rtc-fix

Conversation

@LucasChollet

Copy link
Copy Markdown
Member

See individual commits for details.

I don't think it changes much, it's mainly for consistency with the
other reads/writes.
@github-actions github-actions Bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 29, 2026
Comment thread Kernel/Arch/x86_64/Time/RTC.cpp
Reading the register C let the hardware know that it can send a new
interrupt. Doing it during the initialization sequence allows the RTC
to work as intended if, for some reason, an interrupt was sent before we
started to handle them.

This fixes booting the kernel with `time=legacy`. With this flag
enabled, I've experienced deadlocks inside QEMU 11.0.1 itself but this
works as expected on QEMU 10.2.1.
@spholz spholz merged commit 31622ca into SerenityOS:master Jul 4, 2026
14 checks passed
@github-actions github-actions Bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants