Landing: compact supporters band — link out instead of rotating quote / 首页支持者区改为链接跳转,不再轮播评价 - #884
Closed
functionstackx wants to merge 1 commit into
Closed
Conversation
The mint supporters band no longer renders a rotating quote block; it keeps the org name strip and links out to /quotes via 'See full quotes & more supporters', saving vertical space above the fold. Removes the now-unused QuoteCarousel client component and updates Cypress expectations.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cb1ee28. Configure here.
| cy.get('[data-testid="intro-section"]').should( | ||
| 'contain.text', | ||
| 'See full quotes & more supporters', | ||
| ); |
There was a problem hiding this comment.
Stale supporter logo preload test
Medium Severity
This spec still expects / to preload exactly one supporter logo (/logos/minimax.svg) from the old carousel’s first quote. SupportersStrip only renders org names, so that image is no longer on the landing HTML and the preload assertion fails.
Reviewed by Cursor Bugbot for commit cb1ee28. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the redesign prototype's landing page, the mint supporters band no longer renders the rotating quote text. It now shows just the org name strip plus a "See full quotes & more supporters →" link to
/quotes(zh:/zh/quotes, 「查看完整评价与更多支持者 →」), saving vertical space above the fold.Changes
intro-section.tsx: renders a new compactSupportersStrip(org names + link) instead ofQuoteCarousel; org order/labels still come fromQUOTES/CAROUSEL_ORGS/CAROUSEL_LABELSquote-carousel.tsxclient component (~190 lines of rotation/fade state gone from the landing bundle)quote_carousel_see_more_clickedanalytics event on the link for continuity;quote_carousel_navigatedno longer fires (no in-band navigation)landing-performance.cy.tsexpectations to the new link text andsupporters-more-rowtestidQA
typecheck,lint, andfmtall passBase:
redesign/landing-navbar(prototype, #882)Note
Low Risk
Landing UI and bundle simplification only; no auth, API, or data-path changes. Residual risk is stale Cypress comments/assertions elsewhere in the same file that still describe carousel logo preload behavior.
Overview
The landing intro mint supporters band no longer shows a rotating quote block. It now renders a compact org-name strip and a right-aligned link to
/quotes(zh:/zh/quotes) with copy "See full quotes & more supporters →", shrinking above-the-fold height.intro-sectionswapsQuoteCarouselfor newSupportersStrip, still deriving org order and labels fromQUOTES,CAROUSEL_ORGS, andCAROUSEL_LABELS(no per-quote i18n on the band).quote-carousel.tsxis removed (~190 lines of rotation/fade/client state). The "see more" link keeps thequote_carousel_see_more_clickedanalytics event;quote_carousel_navigatedis gone with in-band carousel navigation.Cypress
landing-performance.cy.tsassertions were updated for the new link text andsupporters-more-rowtest id.Reviewed by Cursor Bugbot for commit cb1ee28. Bugbot is set up for automated code reviews on this repo. Configure here.