feat(app): left sidebar app shell with grouped navigation / 左侧边栏应用外壳与分组导航 - #883
Draft
adibarra wants to merge 2 commits into
Draft
feat(app): left sidebar app shell with grouped navigation / 左侧边栏应用外壳与分组导航#883adibarra wants to merge 2 commits into
adibarra wants to merge 2 commits into
Conversation
From the xl breakpoint up the header renders as a fixed left sidebar: brand on top, primary nav with icons, nested dashboard tabs while a dashboard route is active, a Data & Reference group surfacing deep destinations (rankings, run results, chip specs, reliability, per-dollar, glossary, API), and utilities pinned to the foot. Below xl the shell collapses to the previous sticky top bar with the hamburger menu, so every existing nav-link-* testid, order, and behavior is unchanged. The content column shifts right via xl:pl-72; the minecraft grass strip moves to the sidebar's right edge at xl.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative take on the shell redesign, for comparison with #882: the header becomes a fixed left sidebar from the
xlbreakpoint up, giving the site an app-like frame with far more navigation surface. Builds on the #882 editorial light theme (its landing/footer commit is included on this branch).这是与 #882 对比的另一版外壳重设计：从
xl断点起，顶部导航栏变为固定左侧边栏，为站点提供更接近应用的框架和更充裕的导航空间。本分支包含 #882 的落地页与页脚提交。What changed / 变更内容
xl+ — brand on top, grouped navigation in the middle, utilities (GitHub stars, language, theme, minecraft toggles) pinned to the foot. Belowxlthe shell collapses to the previous sticky top bar with the hamburger menu, so tablet/mobile behavior is untouched.sidebar-tab-*), so tab switching no longer depends on the horizontal tab bar.sidebar-link-*, additive namespace).xl:pl-72; the minecraft grass strip moves from the header underline to the sidebar's right edge atxl; the agentic metric toolbar's sticky offset adjusts atxlsince there is no top bar.Compatibility / 兼容性
header,header-brand,nav-link-*(order preserved),language-toggle,theme-toggle,header-star-button,mobile-menu-toggle,mobile-menu.navigateInAppdouble-push for Overview/Dashboard, current-page no-op, analytics events) is unchanged. New links use additivesidebar-link-*/sidebar-tab-*testids and new analytics events.QA
typecheck,lint,fmtpass. Cypress could not launch in this sandbox (Node/undici env limitation), so the header component contract was re-verified point-by-point with Playwright instead.Screenshots: desktop sidebar (light/dark/minecraft/zh), dashboard sub-tabs, and 320px mobile menu were reviewed during QA.